Conversation
|
@mayeaux
|
|
Looks really good! I like the JSDocs usage I was planning to start that soon so I'm glad you got the ball rolling. Quick question what's this for: Other than that I can merge this right away, thanks my friend! |
It's for better type inference. VSCode comes pre-bundled with Typescript which adds a lot of type info and tooltips and also infers types off JSDoc comments. |
|
@BassOfBass : check the review: this works for you? it throws an error for me TypeError: req.sanitize(...).trim(...).escape is not a function |
|
@mayeaux Guess this version of validator can't into chaining. |
|
@mayeaux please review again. |
alechash
left a comment
There was a problem hiding this comment.
Looks good after validation chaining fix
I believe validator now supports chaining. Any reason not to just update validator in dependencies?
|
@mr-winson |
Fix mentioned in #396 (comment).